From: Christoph Hellwig <hch@infradead.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Carsten Otte <cotte@freenet.de>,
suparna@in.ibm.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
schwidefsky@de.ibm.com, Andrew Morton <akpm@osdl.org>
Subject: Re: [RFC/PATCH 2/4] fs/mm: execute in place (3rd version)
Date: Sat, 28 May 2005 10:05:41 +0100 [thread overview]
Message-ID: <20050528090541.GA19153@infradead.org> (raw)
In-Reply-To: <1117043475.26913.1540.camel@dyn318077bld.beaverton.ibm.com>
On Wed, May 25, 2005 at 10:51:17AM -0700, Badari Pulavarty wrote:
> This is my crude version of the cleanup patch to reduce the
> duplication of code.
>
> Basically, I added __generic_file_aio_read_internal() and
> __generic_file_aio_write_nolock_internal() to take a read/write
> handlers instead of defaulting to do_generic_file_read() or
> generic_file_buffered_write().
>
> This way I was able to reduce 129 lines of your code.
> This patch is on top of your current set and I haven't even
> tried compiling it. Needs cleanup.
>
>
> BTW, function & variable names are too long and/or ugly & doesn't
> make sense - need fixing.
>
> Christoph/Suparna/Andrew, Comments ?
I don't like this patch a lot. It adds another indirection to the code,
and still leaves the O_DIRECT branches in the XIP path that don't make
any sense. If you're looking for a way to consolidate duplicated code
some abtraction for the iovec verification makes most sense, as there's
very little other code duplicated.
next prev parent reply other threads:[~2005-05-28 9:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1116866094.12153.12.camel@cotte.boeblingen.de.ibm.com>
2005-05-23 17:30 ` [RFC/PATCH 2/4] fs/mm: execute in place (3rd version) Carsten Otte
2005-05-24 9:30 ` Suparna Bhattacharya
2005-05-24 10:28 ` Jörn Engel
2005-05-24 11:09 ` Carsten Otte
2005-05-24 13:32 ` Suparna Bhattacharya
2005-05-24 14:34 ` Carsten Otte
2005-05-25 17:51 ` Badari Pulavarty
2005-05-26 13:22 ` Suparna Bhattacharya
2005-05-26 13:19 ` Carsten Otte
2005-05-26 16:43 ` Badari Pulavarty
2005-05-26 13:29 ` Carsten Otte
2005-05-28 9:05 ` Christoph Hellwig [this message]
2005-05-24 17:01 ` Carsten Otte
2005-05-28 9:08 ` Christoph Hellwig
2005-05-23 17:30 ` [RFC/PATCH 3/4] ext2: " Carsten Otte
2005-05-23 17:30 ` [RFC/PATCH 4/4] madvice/fadvice: " Carsten Otte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050528090541.GA19153@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=cotte@freenet.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).