linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: ericvh@gmail.com
Cc: linux-kernel@vger.kernel.org,
	v9fs-developer@lists.sourceforge.net, akpm@osdl.org,
	viro@parcelfarce.linux.theplanet.co.uk,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 7/7] v9fs: debug and support routines (2.0)
Date: Tue, 7 Jun 2005 17:06:39 +0200	[thread overview]
Message-ID: <20050607150638.GD19479@lug-owl.de> (raw)
In-Reply-To: <200506071450.j57EoDe1010866@ms-smtp-02-eri0.texas.rr.com>

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

On Tue, 2005-06-07 09:49:51 -0500, ericvh@gmail.com <ericvh@gmail.com> wrote:
> +++ b/fs/9p/error.h

If you really need to use this struct, ...

> +/* FixMe - reduce to a reasonable size */
> +static struct errormap errmap[] = {
> +	{"Operation not permitted", 1},
> +	{"wstat prohibited", 1},
> +	{"No such file or directory", 2},
> +	{"file not found", 2},
> +	{"Interrupted system call", 4},
> +	{"Input/output error", 5},

...then please use the E macros of errno.h and not these numeric
constants. errno values may vary between ports.

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      parent reply	other threads:[~2005-06-07 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-07 14:49 [PATCH 7/7] v9fs: debug and support routines (2.0) ericvh
2005-06-07 15:03 ` Jan-Benedict Glaw
2005-06-07 15:06 ` Jan-Benedict Glaw [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050607150638.GD19479@lug-owl.de \
    --to=jbglaw@lug-owl.de \
    --cc=akpm@osdl.org \
    --cc=ericvh@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).