From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] pass iocb to dio_iodone_t
Date: Fri, 10 Jun 2005 17:03:02 +0100
Message-ID: <20050610160302.GA8882@infradead.org>
References: <20050610150052.GA1632@lst.de> <1118417101.4301.315.camel@dyn9047017072.beaverton.ibm.com> <20050610154858.GA2766@lst.de> <1118417869.4301.325.camel@dyn9047017072.beaverton.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>, Andrew Morton <akpm@osdl.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:31194 "EHLO
	pentafluge.infradead.org") by vger.kernel.org with ESMTP
	id S262591AbVFJQDI (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 10 Jun 2005 12:03:08 -0400
To: Badari Pulavarty <pbadari@us.ibm.com>
Content-Disposition: inline
In-Reply-To: <1118417869.4301.325.camel@dyn9047017072.beaverton.ibm.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Fri, Jun 10, 2005 at 08:37:49AM -0700, Badari Pulavarty wrote:
> On Fri, 2005-06-10 at 08:48, Christoph Hellwig wrote:
> > On Fri, Jun 10, 2005 at 08:25:01AM -0700, Badari Pulavarty wrote:
> > > Just curious on why XFS needs end_io callback ?
> > 
> > To convert unwritten extents to written extents.
> > 
> > > And also, why is dio->inode != iocb->ki_filp->f_dentry->d_inode
> > > for XFS ?
> > 
> > It's not.
> 
> Hmm.. Then, I don't understand your patch. Is there a follow up
> patch to make use of iocb in linvfs_unwritten_convert_direct() ?

Yes.  It'll go in through the the normal xfs tree merges.

> All you did was, to pass "iocb" instead of "inode". Then got
> inode from "iocb". (which you claimed they are same).
> 
> Am I miss understanding something ?

No, I should have mentioned that this is just a trivial infrastructure
bit, the actual fix is a little more complicated.