From: Mark Fasheh <mark.fasheh@oracle.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
torvalds@osdl.org, akpm@osdl.org,
viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: [PATCH] export generic_drop_inode()
Date: Sat, 11 Jun 2005 00:25:18 -0700 [thread overview]
Message-ID: <20050611072518.GB14537@ca-server1.us.oracle.com> (raw)
In-Reply-To: <42AA8CDF.1020104@yahoo.com.au>
On Sat, Jun 11, 2005 at 05:03:59PM +1000, Nick Piggin wrote:
> I think it is best to default these to EXPORT_SYMBOL_GPL to be on the
> safe side, unless you have the agreement of the authors of the code, in
> which case I beg your pardon.
No problem. I apologize if I stepped on anyone's toes by using EXPORT_SYMBOL
:) Here's a patch using EXPORT_SYMBOL_GPL instead.
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
diff -aur linux-2.6.12-rc6.orig/fs/inode.c linux-2.6.12-rc6/fs/inode.c
--- linux-2.6.12-rc6.orig/fs/inode.c 2005-06-06 08:22:29.000000000 -0700
+++ linux-2.6.12-rc6/fs/inode.c 2005-06-11 00:15:06.000000000 -0700
@@ -1048,7 +1048,7 @@
* inode when the usage count drops to zero, and
* i_nlink is zero.
*/
-static void generic_drop_inode(struct inode *inode)
+void generic_drop_inode(struct inode *inode)
{
if (!inode->i_nlink)
generic_delete_inode(inode);
@@ -1056,6 +1056,8 @@
generic_forget_inode(inode);
}
+EXPORT_SYMBOL_GPL(generic_drop_inode);
+
/*
* Called when we're dropping the last reference
* to an inode.
diff -aur linux-2.6.12-rc6.orig/include/linux/fs.h linux-2.6.12-rc6/include/linux/fs.h
--- linux-2.6.12-rc6.orig/include/linux/fs.h 2005-06-06 08:22:29.000000000 -0700
+++ linux-2.6.12-rc6/include/linux/fs.h 2005-06-10 17:13:18.000000000 -0700
@@ -1411,6 +1411,7 @@
extern ino_t iunique(struct super_block *, ino_t);
extern int inode_needs_sync(struct inode *inode);
extern void generic_delete_inode(struct inode *inode);
+extern void generic_drop_inode(struct inode *inode);
extern struct inode *ilookup5(struct super_block *sb, unsigned long hashval,
int (*test)(struct inode *, void *), void *data);
prev parent reply other threads:[~2005-06-11 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-11 2:18 [PATCH] export generic_drop_inode() Mark Fasheh
2005-06-11 7:03 ` Nick Piggin
2005-06-11 7:25 ` Mark Fasheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050611072518.GB14537@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).