[patch 1/1] Fix misleading gcc4 warning, idx may be used uninitialized

[patch 1/1] Fix misleading gcc4 warning, idx may be used uninitialized

[domen]

[-- Attachment #1: gcc4-fs_bio.c --]
[-- Type: text/plain, Size: 638 bytes --]

From: Jesse Millan <jessem@cs.pdx.edu>



This warning is a false alarm.

This patch eliminates the warning that idx may be used uninitialized in
the function bvec_alloc_bs().


Signed-off-by: Jesse Millan <jessem@cs.pdx.edu>
Signed-off-by: Domen Puncer <domen@coderock.org>

---
 bio.c |    1 +
 1 files changed, 1 insertion(+)

Index: quilt/fs/bio.c
===================================================================
--- quilt.orig/fs/bio.c
+++ quilt/fs/bio.c
@@ -78,6 +78,7 @@ static inline struct bio_vec *bvec_alloc
 {
 	struct bio_vec *bvl;
 	struct biovec_slab *bp;
+	*idx = 0;
 
 	/*
 	 * see comment near bvec_array define!

--

Re: [patch 1/1] Fix misleading gcc4 warning, idx may be used uninitialized

[Jörn Engel]

On Mon, 20 June 2005 23:56:48 +0200, domen@coderock.org wrote:
> 
> This warning is a false alarm.

Yep, it is.  Would be much nicer to teach gcc about it.


Jörn

-- 
"Translations are and will always be problematic. They inflict violence 
upon two languages." (translation from German)
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch 1/1] Fix misleading gcc4 warning, idx may be used uninitialized

[Jens Axboe]

On Mon, Jun 20 2005, domen@coderock.org wrote:
> From: Jesse Millan <jessem@cs.pdx.edu>
> 
> 
> 
> This warning is a false alarm.
> 
> This patch eliminates the warning that idx may be used uninitialized in
> the function bvec_alloc_bs().
> 
> 
> Signed-off-by: Jesse Millan <jessem@cs.pdx.edu>
> Signed-off-by: Domen Puncer <domen@coderock.org>
> 
> ---
>  bio.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> Index: quilt/fs/bio.c
> ===================================================================
> --- quilt.orig/fs/bio.c
> +++ quilt/fs/bio.c
> @@ -78,6 +78,7 @@ static inline struct bio_vec *bvec_alloc
>  {
>  	struct bio_vec *bvl;
>  	struct biovec_slab *bp;
> +	*idx = 0;
>  
>  	/*
>  	 * see comment near bvec_array define!

Rejected, the gcc warning is (as you note) a false alarm. So fix gcc.

-- 
Jens Axboe