From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: XFS corruption on move from xscale to i686 Date: Thu, 14 Jul 2005 15:38:30 +0100 Message-ID: <20050714143830.GA17842@infradead.org> References: <1120756552.5298.10.camel@pc299.sam-solutions.net> <20050708042146.GA1679@frodo> <60868aed0507130822c2e9e97@mail.gmail.com> <20050714012048.GB937@frodo> <60868aed050714065047e3aaec@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nathan Scott , linux-xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tibor@altlinux.ru, pakhuchiy@iptel.by Return-path: To: Yura Pakhuchiy Content-Disposition: inline In-Reply-To: <60868aed050714065047e3aaec@mail.gmail.com> Sender: linux-xfs-bounce@oss.sgi.com Errors-to: linux-xfs-bounce@oss.sgi.com List-Id: linux-fsdevel.vger.kernel.org On Thu, Jul 14, 2005 at 04:50:01PM +0300, Yura Pakhuchiy wrote: > 2005/7/14, Nathan Scott : > > On Wed, Jul 13, 2005 at 06:22:28PM +0300, Yura Pakhuchiy wrote: > > > I found patch by Greg Ungreger to fix this problem, but why it's still > > > not in mainline? Or it's a gcc problem and should be fixed by gcc folks? > > > > Yes, IIRC the patch was incorrect for other platforms, and it sure > > looked like an arm-specific gcc problem (this was ages back, so > > perhaps its fixed by now). > > AFAIR gcc-3.4.3 was released after this conversation take place at linux-xfs, > maybe add something like this: > > #ifdef XSCALE > /* We need this because some gcc versions for xscale are broken. */ > [patched version here] > #else > [original version here] > #endif no, just fix your compiler or let the gcc folks do it. Did anyone of the arm folks ever open a PR at the gcc bugzilla with a reproduced testcase? You're never get your compiler fixed with that attitude.