From: Andreas Dilger <adilger@clusterfs.com>
To: Mingming Cao <cmm@us.ibm.com>
Cc: ext2-devel <ext2-devel@lists.sourceforge.net>,
Andrew Morton <akpm@osdl.org>,
"Stephen C. Tweedie" <sct@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Badari Pulavarty <pbadari@us.ibm.com>,
suparna@in.ibm.com, tytso@mit.edu
Subject: Re: [Ext2-devel] [RFC] [PATCH 2/4]delayed allocation for ext3
Date: Sun, 17 Jul 2005 19:47:43 -0600 [thread overview]
Message-ID: <20050718014743.GB6427@schatzie.adilger.int> (raw)
In-Reply-To: <1121622041.4609.25.camel@localhost.localdomain>
On Jul 17, 2005 10:40 -0700, Mingming Cao wrote:
> @@ -373,6 +373,7 @@ struct ext3_inode {
> #define EXT3_MOUNT_BARRIER 0x20000 /* Use block barriers */
> #define EXT3_MOUNT_NOBH 0x40000 /* No bufferheads */
> #define EXT3_MOUNT_QUOTA 0x80000 /* Some quota option set */
> + #define EXT3_MOUNT_DELAYED_ALLOC 0xC0000 /* Delayed Allocation */
This doesn't make sense. DELAYED_ALLOC == QUOTA | NOBH?
> + {Opt_delayed_alloc, "delalloc"},
Is this a replacement for Alex's delalloc code? We also use delalloc for
that code and if they are not interchangeable it will cause confusion
about which one is in use.
> + if (test_opt(sb, DELAYED_ALLOC)) {
> + if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) {
> + printk(KERN_WARNING "EXT3-fs: Ignoring delall option - "
> + "its supported only with writeback mode\n");
Should be "ignoring delalloc option".
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2005-07-18 15:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1110839154.24286.302.camel@dyn318077bld.beaverton.ibm.com>
2005-07-17 17:40 ` [RFC] [PATCH 0/4]Multiple block allocation and delayed allocation for ext3 Mingming Cao
2005-07-17 17:45 ` Mingming Cao
2005-07-17 17:40 ` [RFC] [PATCH 1/4]Multiple block " Mingming Cao
2005-07-17 17:40 ` [RFC] [PATCH 2/4]delayed " Mingming Cao
2005-07-18 1:47 ` Andreas Dilger [this message]
2005-07-18 17:32 ` [Ext2-devel] " Mingming Cao
2005-07-19 0:25 ` Badari Pulavarty
2005-07-26 22:52 ` Andrew Morton
2005-07-26 22:55 ` Badari Pulavarty
2005-07-17 17:40 ` [RFC] [PATCH 3/4]generic getblocks() support in mpage_writepages Mingming Cao
2005-07-17 17:41 ` [RFC] [PATCH 4/4]add ext3 writeback writpages Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050718014743.GB6427@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=sct@redhat.com \
--cc=suparna@in.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).