From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Dilger Subject: Re: [Ext2-devel] [RFC] [PATCH 2/4]delayed allocation for ext3 Date: Sun, 17 Jul 2005 19:47:43 -0600 Message-ID: <20050718014743.GB6427@schatzie.adilger.int> References: <1110839154.24286.302.camel@dyn318077bld.beaverton.ibm.com> <1121622041.4609.25.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ext2-devel , Andrew Morton , "Stephen C. Tweedie" , linux-kernel , linux-fsdevel@vger.kernel.org, Badari Pulavarty , suparna@in.ibm.com, tytso@mit.edu Return-path: Received: from moraine.clusterfs.com ([66.96.26.190]:32170 "EHLO moraine.clusterfs.com") by vger.kernel.org with ESMTP id S261533AbVGRPs0 (ORCPT ); Mon, 18 Jul 2005 11:48:26 -0400 To: Mingming Cao Content-Disposition: inline In-Reply-To: <1121622041.4609.25.camel@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Jul 17, 2005 10:40 -0700, Mingming Cao wrote: > @@ -373,6 +373,7 @@ struct ext3_inode { > #define EXT3_MOUNT_BARRIER 0x20000 /* Use block barriers */ > #define EXT3_MOUNT_NOBH 0x40000 /* No bufferheads */ > #define EXT3_MOUNT_QUOTA 0x80000 /* Some quota option set */ > + #define EXT3_MOUNT_DELAYED_ALLOC 0xC0000 /* Delayed Allocation */ This doesn't make sense. DELAYED_ALLOC == QUOTA | NOBH? > + {Opt_delayed_alloc, "delalloc"}, Is this a replacement for Alex's delalloc code? We also use delalloc for that code and if they are not interchangeable it will cause confusion about which one is in use. > + if (test_opt(sb, DELAYED_ALLOC)) { > + if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) { > + printk(KERN_WARNING "EXT3-fs: Ignoring delall option - " > + "its supported only with writeback mode\n"); Should be "ignoring delalloc option". Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.