From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: Kernel bug: Bad page state: related to generic symlink code and mmap Date: Fri, 19 Aug 2005 19:00:38 +0100 Message-ID: <20050819180037.GA5686@infradead.org> References: <1124450088.2294.31.camel@imp.csi.cam.ac.uk> <20050819142025.GA29811@parcelfarce.linux.theplanet.co.uk> <1124466246.2294.65.camel@imp.csi.cam.ac.uk> <20050819165332.GD29811@parcelfarce.linux.theplanet.co.uk> <20050819180218.GE29811@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Anton Altaparmakov , vandrove@vc.cvut.cz, Andrew Morton , linware@sh.cvut.cz, fsdevel , lkml Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:63951 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S965035AbVHSSAo (ORCPT ); Fri, 19 Aug 2005 14:00:44 -0400 To: Al Viro Content-Disposition: inline In-Reply-To: <20050819180218.GE29811@parcelfarce.linux.theplanet.co.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Aug 19, 2005 at 07:02:18PM +0100, Al Viro wrote: > On Fri, Aug 19, 2005 at 05:53:32PM +0100, Al Viro wrote: > > I'm taking NFS helpers to libfs.c and switching ncpfs to them. IMO that's > > better than copying the damn thing and other network filesystems might have > > the same needs eventually... > > [something like this - completely untested] > > * stray_page_get_link(inode, filler) - returns ERR_PTR(error) or pointer > to symlink body. Said symlink body sits in a page at offset equal to > offsetof(page, struct stray_page_link). filler() is expected to put it > at such offset. Page is cached. > > * stray_page_put_link() - ->put_link() suitable for links obtained from > stray_page_get_link(). Unlike the usual pagecache-based variants, this > sucker does _not_ rely on page staying cached. > > * nfs and ncpfs switched to the helpers above. Can you add some kerneldoc comments to describe them? Especially as the name is not very descriptive.