From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: Re: GFS, what's remaining Date: Sat, 3 Sep 2005 18:32:41 -0700 Message-ID: <20050903183241.1acca6c9.akpm@osdl.org> References: <20050901104620.GA22482@redhat.com> <200509030242.36506.phillips@istop.com> <20050903064633.GB4593@ca-server1.us.oracle.com> <200509031821.27070.phillips@istop.com> <20050904010912.GJ8684@ca-server1.us.oracle.com> Reply-To: linux clustering Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cluster@redhat.com, ak@suse.de Return-path: To: Joel Becker In-Reply-To: <20050904010912.GJ8684@ca-server1.us.oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cluster-bounces@redhat.com Errors-To: linux-cluster-bounces@redhat.com List-Id: linux-fsdevel.vger.kernel.org Joel Becker wrote: > > On Sat, Sep 03, 2005 at 06:21:26PM -0400, Daniel Phillips wrote: > > that fit the configfs-nee-sysfs model? If it does, the payoff will be about > > 500 lines saved. > > I'm still awaiting your merge of ext3 and reiserfs, because you > can save probably 500 lines having a filesystem that can create reiser > and ext3 files at the same time. oy. Daniel is asking a legitimate question. If there's duplicated code in there then we should seek to either make the code multi-purpose or place the common or reusable parts into a library somewhere. If neither approach is applicable or practical for *every single function* then fine, please explain why. AFAIR that has not been done.