From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: NFS4 crack Date: Sun, 18 Sep 2005 12:21:00 +0200 Message-ID: <20050918102100.GA23463@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:35725 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S1750860AbVIRKVu (ORCPT ); Sun, 18 Sep 2005 06:21:50 -0400 To: akpm@osdl.org, neilb@cse.unsw.edu.au, andros@citi.umich.edu, bfields@citi.umich.edu Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org I've recently turned on NFS4 server support accidentally, just to get error messages like: "NFSD: recovery directory /var/lib/nfs/v4recovery doesn't exist" To my horror I found out that this comes from kernel code, which messes with a hardcoded directory, completelyu ingoring any namespace or other uses issues. The fs handling in fs/nfs/nfs4recovery.c is rather broken in addition. All this comes from "[PATCH] knfsd: nfsd4: initialize recovery directory", commit ID 190e4fbf96037e5e526ba3210f2bcc2a3b6fe964. Andrew, could you please back this out again, and NFS folks, please don't do stuff like that and hide your crackpipe somewhere. And please we really need someone sane review NFS patches I thinkg. (not cc'ed to the nfs list because of its stupid subsribers only policy)