From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: NFS4 crack Date: Mon, 19 Sep 2005 15:39:21 +0200 Message-ID: <20050919133921.GA12208@lst.de> References: <20050918102100.GA23463@lst.de> <20050918143615.GA3428@fieldses.org> <20050919103547.GA8998@lst.de> <20050919133528.GA20732@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , akpm@osdl.org, neilb@cse.unsw.edu.au, andros@citi.umich.edu, linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:38573 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S932385AbVISNjz (ORCPT ); Mon, 19 Sep 2005 09:39:55 -0400 To: "J. Bruce Fields" Content-Disposition: inline In-Reply-To: <20050919133528.GA20732@fieldses.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Sep 19, 2005 at 09:35:28AM -0400, J. Bruce Fields wrote: > On Mon, Sep 19, 2005 at 12:35:47PM +0200, Christoph Hellwig wrote: > > Namespaces issues above was meant as kernel can't assume namespace at > > all, not even thinking about multiple namespaces which makes it even > > more wrong. Who sais I allow the kernel to mess with > > /var/lib/nfs/v4recover? > > It's run-time configurable if you don't like the default. > > > Who tells any userspace process is even in the same namespace as the > > nfs threads to create the directories? > > No userspace process is likely to care, except maybe for debugging > purposes. This isn't a userspace<->kernel interface, it's just a way to > store some information on disk so nfsd can find it again on next boot. Again, FILENAMES ARE POLICY AND HAVE NO BUSINESS IN THE KERNEL if that wasn't clear enough. You can't contiune enumerating the special cases in that i could actually work somehow, but that doesn't make the code any better. We have a strong policy to not have hardcoded filenames in the kernel (although a few week abstractions where we pass something very similar to a filename up to userspace to act on it), and we're not going to make an exception for NFSv4. Especially as this code would be much simpler in userspace as already mentioned. Directory handling is something that can't be done sanely in kernelspace.