From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@osdl.org, neilb@cse.unsw.edu.au, andros@citi.umich.edu,
linux-fsdevel@vger.kernel.org
Subject: Re: NFS4 crack
Date: Mon, 19 Sep 2005 15:11:53 +0100 [thread overview]
Message-ID: <20050919141153.GA22477@infradead.org> (raw)
In-Reply-To: <20050919140715.GC20732@fieldses.org>
On Mon, Sep 19, 2005 at 10:07:15AM -0400, J. Bruce Fields wrote:
> > > No userspace process is likely to care, except maybe for debugging
> > > purposes. This isn't a userspace<->kernel interface, it's just a way to
> > > store some information on disk so nfsd can find it again on next boot.
> >
> > Again,
> >
> > FILENAMES ARE POLICY AND HAVE NO BUSINESS IN THE KERNEL
>
> What problem does this create in this case?
>
> The "hardcoded" path is just a default for a value that can be modified
> at runtime.
Umm, that's not the point at all. Pathnames are user policy and they
shouldn't be used from the kernel even configurable. File access from
kernelspace should be avoided whenver possible. NFSD is exception as
it needs to access file as part of it's job, but that exception doesn't
give it a wildcard to do random crap.
And the other point is that the code is utter crap and could be done
much better in userspace.
next prev parent reply other threads:[~2005-09-19 14:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 10:21 NFS4 crack Christoph Hellwig
2005-09-18 14:36 ` J. Bruce Fields
2005-09-19 10:35 ` Christoph Hellwig
2005-09-19 13:04 ` Anton Altaparmakov
2005-09-19 13:35 ` J. Bruce Fields
2005-09-19 13:39 ` Christoph Hellwig
2005-09-19 14:07 ` J. Bruce Fields
2005-09-19 14:11 ` Christoph Hellwig [this message]
2005-09-19 17:13 ` Bryan Henderson
2005-09-19 17:16 ` Randy.Dunlap
2005-09-19 21:57 ` Bryan Henderson
2005-09-19 22:11 ` Randy.Dunlap
2005-09-20 0:17 ` Bryan Henderson
2005-09-19 18:02 ` Christoph Hellwig
2005-09-19 18:53 ` William A.(Andy) Adamson
2005-09-19 18:59 ` Christoph Hellwig
2005-09-19 22:04 ` Bryan Henderson
2005-09-19 19:01 ` J. Bruce Fields
2005-09-19 19:05 ` Christoph Hellwig
2005-09-19 20:31 ` J. Bruce Fields
2005-09-20 12:49 ` Greg KH
2005-09-20 15:10 ` William A.(Andy) Adamson
2005-09-20 18:37 ` Neil Brown
2005-09-21 7:44 ` Andrew Morton
2005-09-22 20:58 ` William A.(Andy) Adamson
2005-09-21 13:41 ` Trond Myklebust
2005-09-21 14:40 ` J. Bruce Fields
2005-09-22 16:28 ` Bryan Henderson
2005-09-22 16:52 ` Trond Myklebust
2005-09-22 17:38 ` Peter Staubach
2005-09-22 17:52 ` Trond Myklebust
2005-09-22 18:07 ` Peter Staubach
2005-09-22 21:08 ` Bryan Henderson
2005-09-23 12:17 ` Peter Staubach
2005-09-23 20:50 ` Bryan Henderson
2005-09-23 21:02 ` NFS4 crack\ Al Viro
2005-09-26 16:29 ` Bryan Henderson
2005-09-26 17:13 ` Peter Staubach
2005-09-22 21:48 ` NFS4 crack Nicholas Miell
2005-09-22 22:50 ` Greg Banks
2005-09-22 21:19 ` Bryan Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050919141153.GA22477@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=andros@citi.umich.edu \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).