From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: NFS4 crack Date: Mon, 19 Sep 2005 15:11:53 +0100 Message-ID: <20050919141153.GA22477@infradead.org> References: <20050918102100.GA23463@lst.de> <20050918143615.GA3428@fieldses.org> <20050919103547.GA8998@lst.de> <20050919133528.GA20732@fieldses.org> <20050919133921.GA12208@lst.de> <20050919140715.GC20732@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , akpm@osdl.org, neilb@cse.unsw.edu.au, andros@citi.umich.edu, linux-fsdevel@vger.kernel.org Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:62933 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932422AbVISOMD (ORCPT ); Mon, 19 Sep 2005 10:12:03 -0400 To: "J. Bruce Fields" Content-Disposition: inline In-Reply-To: <20050919140715.GC20732@fieldses.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Sep 19, 2005 at 10:07:15AM -0400, J. Bruce Fields wrote: > > > No userspace process is likely to care, except maybe for debugging > > > purposes. This isn't a userspace<->kernel interface, it's just a way to > > > store some information on disk so nfsd can find it again on next boot. > > > > Again, > > > > FILENAMES ARE POLICY AND HAVE NO BUSINESS IN THE KERNEL > > What problem does this create in this case? > > The "hardcoded" path is just a default for a value that can be modified > at runtime. Umm, that's not the point at all. Pathnames are user policy and they shouldn't be used from the kernel even configurable. File access from kernelspace should be avoided whenver possible. NFSD is exception as it needs to access file as part of it's job, but that exception doesn't give it a wildcard to do random crap. And the other point is that the code is utter crap and could be done much better in userspace.