From: Suparna Bhattacharya <suparna@in.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Nikita Danilov <nikita@clusterfs.com>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH, RFC] map multiple blocks at a time in mpage_readpage(s)
Date: Wed, 5 Oct 2005 21:41:59 +0530 [thread overview]
Message-ID: <20051005161158.GA4444@in.ibm.com> (raw)
In-Reply-To: <20051005071037.GA27081@lst.de>
On Wed, Oct 05, 2005 at 09:10:37AM +0200, Christoph Hellwig wrote:
> On Wed, Oct 05, 2005 at 10:04:48AM +0400, Nikita Danilov wrote:
> > > page->index, GFP_KERNEL)) {
> > > bio = do_mpage_readpage(bio, page,
> > > nr_pages - page_idx,
> > > - &last_block_in_bio, get_block);
> > > + &last_block_in_bio, &map_bh,
> > > + &first_logical_block, &map_valid,
> > > + get_blocks, get_block);
> >
> > Oh, function taking 9 arguments, please... this is not windows.
>
> I'm happy about suggestion to reduce the count. One of the real
> problems is that the buffer_head structure is extremly badly suited for
> the get_blocks callback. Having information like in the xfs_iomap_t
> structure (which is XFS bmap information container) would simplify lots
> of these things.
In the writepages case, I ultimately ended up defining an mpageio
structure somewhat like the DIO code.
>
>
> > By the way, I cannot see where get_block callback is used by mpage.c
> > code, why is it needed?
>
> It's only used by block_read_full_page which is called in the 'confused'
> case.
Having a readpage_fn callback may be a little bit better than this, but
yes this is when one really starts wanting to get rid of bufferheads ...
> -
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Regards
Suparna
--
Suparna Bhattacharya (suparna@in.ibm.com)
Linux Technology Center
IBM Software Lab, India
next prev parent reply other threads:[~2005-10-05 16:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 19:42 [PATCH, RFC] map multiple blocks at a time in mpage_readpage(s) Christoph Hellwig
2005-10-04 22:05 ` Dave Kleikamp
2005-10-04 23:15 ` Badari Pulavarty
2005-10-05 7:14 ` Christoph Hellwig
2005-10-07 22:13 ` Badari Pulavarty
2005-10-05 6:04 ` Nikita Danilov
2005-10-05 7:10 ` Christoph Hellwig
2005-10-05 16:11 ` Suparna Bhattacharya [this message]
2005-10-19 11:56 ` Christoph Hellwig
2005-10-19 15:07 ` Dave Kleikamp
2005-10-20 22:06 ` Andrew Morton
2005-10-21 6:18 ` Suparna Bhattacharya
2005-10-21 12:53 ` Dave Kleikamp
2005-10-21 14:16 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051005161158.GA4444@in.ibm.com \
--to=suparna@in.ibm.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).