From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] replace inode_update_time with file_update_time Date: Mon, 31 Oct 2005 23:57:05 +0100 Message-ID: <20051031225705.GA20411@lst.de> References: <20051029165209.GA26446@lst.de> <20051031145419.68938e63.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:59557 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S964879AbVJaW5M (ORCPT ); Mon, 31 Oct 2005 17:57:12 -0500 To: Andrew Morton Content-Disposition: inline In-Reply-To: <20051031145419.68938e63.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Oct 31, 2005 at 02:54:19PM -0800, Andrew Morton wrote: > Christoph Hellwig wrote: > > > > struct timespec now; > > ... > > + inode->i_ctime = now; > > hm, that nonatomic assignment is racy wrt readers and, conceivably, other > writers. this function is always called under i_sem