linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: hch@lst.de, akpm@osdl.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] add support for vectored and async I/O to all simple filesystems
Date: Tue, 1 Nov 2005 16:27:10 +0100	[thread overview]
Message-ID: <20051101152710.GA1762@lst.de> (raw)
In-Reply-To: <E1EWtNh-0006Tx-00@dorka.pomaz.szeredi.hu>

On Tue, Nov 01, 2005 at 11:28:41AM +0100, Miklos Szeredi wrote:
> > Every filesystem using generic_file_read/generic_file_write directly
> > can easily support vectored and async (well at least the API, it's not
> > async quite yet in mainline) I/O.  This patch adds the proper vectors
> > to all filesystems and switches them to do_sync_read/do_sync_write.
> 
> Do you really need to replace generic_file_read/write with
> do_sync_read/write?  That seems to only add overhead.

do_sync_read/write are doing the same thing as generic_file_read/write,
just above the method vectors.  Once I have all filesystems support
proper vectored and aio methods do_sync_read/write will go away
completly and upper code will always call the complex methods (
or hopefull just one cmobined aio/vectored ops with all fancies)
directly.

> 
> The rest of the patch I agree with.
> 
> Miklos
---end quoted text---

  reply	other threads:[~2005-11-01 15:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-01  2:36 [PATCH] add support for vectored and async I/O to all simple filesystems Christoph Hellwig
2005-11-01 10:28 ` Miklos Szeredi
2005-11-01 15:27   ` Christoph Hellwig [this message]
2005-11-01 17:19     ` Miklos Szeredi
2005-11-07  5:00       ` Christoph Hellwig
2005-11-01 19:20 ` Jamie Lokier
2005-11-01 20:57   ` Benjamin LaHaise
2005-11-02 11:06     ` Jamie Lokier
2005-11-02 16:21       ` Benjamin LaHaise
2005-11-02 16:29         ` Matthew Wilcox
2005-11-02 16:45           ` Benjamin LaHaise
2005-11-02 20:31           ` Jamie Lokier
2005-11-02 21:04             ` Anton Altaparmakov
2005-11-02 23:36               ` Jamie Lokier
2005-11-05  0:18   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051101152710.GA1762@lst.de \
    --to=hch@lst.de \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).