From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] add support for vectored and async I/O to all simple filesystems Date: Tue, 1 Nov 2005 16:27:10 +0100 Message-ID: <20051101152710.GA1762@lst.de> References: <20051101023656.GA23724@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@lst.de, akpm@osdl.org, linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:53177 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S1750881AbVKAP1R (ORCPT ); Tue, 1 Nov 2005 10:27:17 -0500 To: Miklos Szeredi Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Nov 01, 2005 at 11:28:41AM +0100, Miklos Szeredi wrote: > > Every filesystem using generic_file_read/generic_file_write directly > > can easily support vectored and async (well at least the API, it's not > > async quite yet in mainline) I/O. This patch adds the proper vectors > > to all filesystems and switches them to do_sync_read/do_sync_write. > > Do you really need to replace generic_file_read/write with > do_sync_read/write? That seems to only add overhead. do_sync_read/write are doing the same thing as generic_file_read/write, just above the method vectors. Once I have all filesystems support proper vectored and aio methods do_sync_read/write will go away completly and upper code will always call the complex methods ( or hopefull just one cmobined aio/vectored ops with all fancies) directly. > > The rest of the patch I agree with. > > Miklos ---end quoted text---