From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [Patch] add AOP_TRUNCATED_PAGE, prepend AOP_ to WRITEPAGE_ACTIVATE Date: Thu, 3 Nov 2005 16:53:06 +0000 Message-ID: <20051103165306.GA4923@infradead.org> References: <43667913.4030401@oracle.com> <20051103124536.0191bea6.akpm@osdl.org> <20051103074312.GQ11488@ca-server1.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:57748 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1030349AbVKCQxN (ORCPT ); Thu, 3 Nov 2005 11:53:13 -0500 To: Andrew Morton , Zach Brown , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, mark.fasheh@oracle.com Content-Disposition: inline In-Reply-To: <20051103074312.GQ11488@ca-server1.us.oracle.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Nov 02, 2005 at 11:43:12PM -0800, Joel Becker wrote: > > Looks sane to me. Can you carry this in the ocfs2 tree? > > No problem. Give us a day or two to merge the changes to our > main trees. I think I disagree with Andew here. Having a core patch separate from a new drivers/filesystem/etc.. is always a good idea. It makes reviewing a lot easier and allows independant handling, e.g. merging it earlier than the new driver for some reason - as happened for example with the clear_inode changes we needed earlier for ocfs or the pagevec exports that came in via the reiser4 patches but were needed in mainline for cifs now.