From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/2] remove update_atime Date: Sat, 5 Nov 2005 00:34:13 +0000 Message-ID: <20051105003413.GA25578@infradead.org> References: <20051104223022.GB9608@lst.de> <20051105003138.GJ31368@schatzie.adilger.int> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:61911 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751368AbVKEAeP (ORCPT ); Fri, 4 Nov 2005 19:34:15 -0500 To: Christoph Hellwig , akpm@osdl.org, linux-fsdevel@vger.kernel.org Content-Disposition: inline In-Reply-To: <20051105003138.GJ31368@schatzie.adilger.int> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Nov 04, 2005 at 05:31:38PM -0700, Andreas Dilger wrote: > On Nov 04, 2005 23:30 +0100, Christoph Hellwig wrote: > > all callers use touch_atime now which takes a vfsmount and allows us > > to implement per-mount noatime. > > > -EXPORT_SYMBOL(update_atime); > > +EXPORT_SYMBOL(touch_atime); > > I would prefer to deprecate update_atime(), instead of removing it > entirely, because it is an exported symbol. No. I need to fix some nast corner cases in XFS, hopefully done this weekend and after that we can commit pre-mountpoint noatime. Any filesystem still using update_atime will silently break with this change otherwise.