From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] replace inode_update_time with file_update_time Date: Tue, 8 Nov 2005 05:30:54 +0100 Message-ID: <20051108043054.GA8531@lst.de> References: <20051029165209.GA26446@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , akpm@osdl.org, linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:17294 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S1030276AbVKHEbH (ORCPT ); Mon, 7 Nov 2005 23:31:07 -0500 To: Anton Altaparmakov Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Nov 07, 2005 at 09:40:51PM +0000, Anton Altaparmakov wrote: > On Sat, 29 Oct 2005, Christoph Hellwig wrote: > > To allow various options to work per-mount instead of per-sb we need > > What are those various options? Please spell them out. (I mean it! I > really do not know what you have in mind and I cannot see anything that > would require a vfs mount wrt cmtime updates.) The ones I work now are noatime and read-only. > I believe your patch is wrong/unnecessary because the only option that is > per superblock (or in your new world per vfsmount) is the IS_RDONLY(inode) > check and if a mount is read-only the VFS should never have allowed > inode/file_update_time() to be called. The codepath should have been > aborted _much_ earlier than that so it does not make any sense to test for > read-only here thus it is not necessary to do a per mountpoint check. > Instead we should remove the readonly check altogether and if there are > any places where an update of cmtime is attempted on a read-only mount we > should fix those instead... > > A more detailed justification for your patch is IMO required before it be > applied to mainline, especially as it breaks existing file systems like > ntfs (as discussed offlist). Besides the above usage it's a nice cleanup and already found bugs like the API abuse in ntfs ->truncate.