Re: [PATCH] replace inode_update_time with file_update_time

[Christoph Hellwig <hch@lst.de>]

On Mon, Nov 07, 2005 at 10:02:01PM +0000, Anton Altaparmakov wrote:
> But that is my point!  A read-only bind mount is just like any other 
> read-only mount and should never even try to update metadata.
> 
> Which codepaths cause inode/file_update_time() to be called for a 
> read-only mount?

The callers right now are the write methods of the various filesystems,
so you are right indeed that we shouldn't need it.

> I do not believe there are any!
> 
> And assuming that I am correct this makes the IS_RDONLY() check 
> pointless and this in turn makes the whole patch pointless

Yes, I think you're right here that we can removed it.

> and given it 
> breaks existing file systems it should be sent to the nirvana of useless 
> patches.

and here I disagree. Given that the only intended use of this function
is to be used in the ->write methods the file is a useful argument.  The
only other use that sneaked in recently is ntfs ->truncate that
shouldn't use and has been fixed by a patch I sent offlist.