From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] replace inode_update_time with file_update_time Date: Tue, 8 Nov 2005 05:34:12 +0100 Message-ID: <20051108043412.GB8531@lst.de> References: <20051029165209.GA26446@lst.de> <1131400349.8063.7.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Shaya Potter , Christoph Hellwig , akpm@osdl.org, linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:27022 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S1030290AbVKHEe3 (ORCPT ); Mon, 7 Nov 2005 23:34:29 -0500 To: Anton Altaparmakov Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Nov 07, 2005 at 10:02:01PM +0000, Anton Altaparmakov wrote: > But that is my point! A read-only bind mount is just like any other > read-only mount and should never even try to update metadata. > > Which codepaths cause inode/file_update_time() to be called for a > read-only mount? The callers right now are the write methods of the various filesystems, so you are right indeed that we shouldn't need it. > I do not believe there are any! > > And assuming that I am correct this makes the IS_RDONLY() check > pointless and this in turn makes the whole patch pointless Yes, I think you're right here that we can removed it. > and given it > breaks existing file systems it should be sent to the nirvana of useless > patches. and here I disagree. Given that the only intended use of this function is to be used in the ->write methods the file is a useful argument. The only other use that sneaked in recently is ntfs ->truncate that shouldn't use and has been fixed by a patch I sent offlist.