From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH 13/18] shared mounts handling: move
Date: Wed, 9 Nov 2005 14:33:15 +0000
Message-ID: <20051109143315.GW7992@ftp.linux.org.uk>
References: <E1EZInj-0001F1-Aj@ZenIV.linux.org.uk> <E1EZnuQ-0001Bg-00@dorka.pomaz.szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linuxram@us.ibm.com
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1751042AbVKIOdS@vger.kernel.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Content-Disposition: inline
In-Reply-To: <E1EZnuQ-0001Bg-00@dorka.pomaz.szeredi.hu>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Nov 09, 2005 at 12:14:30PM +0100, Miklos Szeredi wrote:
> > From: Ram Pai <linuxram@us.ibm.com>
> > Date: 1131402003 -0500
> > 
> > Handling of mount --move in presense of shared mounts (see
> > Documentation/sharedsubtree.txt in the end of patch series
> > for detailed description).
> 
> This patch seems to be totally wrong.  It copies the mounts instead of
> moving them in the propagated cases.
> 
> Am I missing something?

Yes, you are.  We move a single subtree (which has no peers at all)
to mountpoint that gives propagation.  The subtree itself gets moved
to specified mountpoint; for the rest of points in propagation tree
of that mountpoint we have no choice but to create copies.