From: Al Viro <viro@ftp.linux.org.uk>
To: Peter Staubach <staubach@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] handling 64bit values for st_ino]
Date: Thu, 10 Nov 2005 14:04:19 +0000 [thread overview]
Message-ID: <20051110140419.GF7992@ftp.linux.org.uk> (raw)
In-Reply-To: <4373508F.9060004@redhat.com>
On Thu, Nov 10, 2005 at 08:52:15AM -0500, Peter Staubach wrote:
> Two different sized types to describe inode numbers, different paths, etc.
> Having two of something, when just one would suffice, is usually more
> complicated.
_What_ different paths? And what "two of something"?
The only requirement for fs that want to report wider st_ino is
to put the right value into kstat->ino in their ->getattr().
And there's already a plenty of filesystems using iget5() et.al.
for icache lookups - this isn't adding anything new.
As far as 64bit ino_t is concerned - no, thanks. We'd need to walk through
all existing fs code and audit existing uses of ino_t. Which is far more
of support burden.
And then there's an issue of overhead on normal icache lookups for nearly
all existing filesystems; ones that do wider lookup keys are *already* using
iget5(), BTW. So you'll simply punish all users of iget().
next prev parent reply other threads:[~2005-11-10 14:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-10 0:30 [PATCH 1/2] handling 64bit values for st_ino] Al Viro
2005-11-10 12:57 ` Peter Staubach
2005-11-10 13:43 ` Al Viro
2005-11-10 13:52 ` Peter Staubach
2005-11-10 14:04 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-10 16:50 Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051110140419.GF7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=staubach@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).