linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: akpm@osdl.org
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH] add some notes on file_update_time
Date: Fri, 11 Nov 2005 00:38:18 +0100	[thread overview]
Message-ID: <20051110233818.GA19368@lst.de> (raw)

add some notes on why this function should only be used in the write
methods, and what NOCTIME is about.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/fs/inode.c
===================================================================
--- linux-2.6.orig/fs/inode.c	2005-11-08 12:57:19.000000000 +0100
+++ linux-2.6/fs/inode.c	2005-11-08 12:57:19.000000000 +0100
@@ -1211,7 +1211,12 @@
  *	@file: file accessed
  *
  *	Update the mtime and ctime members of an inode and mark the inode
- *	for writeback.
+ *	for writeback.  Note that this function is meant exclusively for
+ *	usage in the file write path of filesystems, and filesystems may
+ *	chose to explicitly ignore update via this function with the
+ *	S_NOCTIME inode flag, e.g. for network filesystem where these
+ *	timestamps are handled by the server.  All explicit ctime/mtime
+ *	updates must be done via notify_change().
  */
 
 void file_update_time(struct file *file)

             reply	other threads:[~2005-11-10 23:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-10 23:38 Christoph Hellwig [this message]
2005-11-10 23:41 ` [PATCH] add some notes on file_update_time Anton Altaparmakov
2005-11-10 23:45   ` Christoph Hellwig
2005-11-10 23:47     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051110233818.GA19368@lst.de \
    --to=hch@lst.de \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).