From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: [PATCH] add some notes on file_update_time Date: Fri, 11 Nov 2005 00:38:18 +0100 Message-ID: <20051110233818.GA19368@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:36829 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S1751236AbVKJXiY (ORCPT ); Thu, 10 Nov 2005 18:38:24 -0500 To: akpm@osdl.org Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org add some notes on why this function should only be used in the write methods, and what NOCTIME is about. Signed-off-by: Christoph Hellwig Index: linux-2.6/fs/inode.c =================================================================== --- linux-2.6.orig/fs/inode.c 2005-11-08 12:57:19.000000000 +0100 +++ linux-2.6/fs/inode.c 2005-11-08 12:57:19.000000000 +0100 @@ -1211,7 +1211,12 @@ * @file: file accessed * * Update the mtime and ctime members of an inode and mark the inode - * for writeback. + * for writeback. Note that this function is meant exclusively for + * usage in the file write path of filesystems, and filesystems may + * chose to explicitly ignore update via this function with the + * S_NOCTIME inode flag, e.g. for network filesystem where these + * timestamps are handled by the server. All explicit ctime/mtime + * updates must be done via notify_change(). */ void file_update_time(struct file *file)