From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 0/12] FS-Cache: Generic filesystem caching facility Date: Mon, 14 Nov 2005 15:03:47 -0800 Message-ID: <20051114150347.1188499e.akpm@osdl.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org Return-path: To: Linus Torvalds In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-Id: linux-fsdevel.vger.kernel.org Linus Torvalds wrote: > > On Mon, 14 Nov 2005, David Howells wrote: > > > > This series of patches does four things: > > Ok, interesting, and I like most of what I see.. Less impressed. It (still) adds a very large amount of tricksy code which pokes around in core pagecache functions, slows down the radix-tree hotpath, exports mysterious symbols. And that's on a 60-second scan. It'll be a sizeable job going through it in detail. Not as sizeable as writing it though ;) All of this for an undisclosed speedup of AFS! I think we need an NFS implementation and some numbers which make it interesting. Or at least, some AFS numbers, some explanation as to why they can be extrapolated to NFS and some degree of interest from the NFS guys. Ditto CIFS. Because it _is_ a lot of code.