From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Blaisorblade <blaisorblade@yahoo.it>,
aia21@cantab.net, dhowells@redhat.com, dwmw2@infradead.org,
green@linuxhacker.ru, hch@lst.de, jdike@addtoit.com,
linux-fsdevel@vger.kernel.org, miklos@szeredi.hu,
neilb@cse.unsw.edu.au, reiserfs-dev@namesys.com,
rmk@arm.linux.org.uk, trond.myklebust@fys.uio.no,
zippel@linux-m68k.org, mm-commits@vger.kernel.org
Subject: Re: + fix-possible-page_cache_shift-overflows.patch added to -mm tree
Date: Thu, 24 Nov 2005 11:02:39 +0100 [thread overview]
Message-ID: <20051124100239.GA11074@lst.de> (raw)
In-Reply-To: <20051123170903.356b42fc.akpm@osdl.org>
On Wed, Nov 23, 2005 at 05:09:03PM -0800, Andrew Morton wrote:
> > > + start = (long long)page->index << PAGE_CACHE_SHIFT;
instead of a construct like this please always use page_offset()
next prev parent reply other threads:[~2005-11-24 10:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 21:22 + fix-possible-page_cache_shift-overflows.patch added to -mm tree akpm
2005-11-23 22:01 ` ntfs - was: " Anton Altaparmakov
2005-11-24 1:00 ` Blaisorblade
2005-11-24 1:09 ` Andrew Morton
2005-11-24 1:37 ` Blaisorblade
2005-11-24 10:02 ` Christoph Hellwig [this message]
2005-11-24 7:05 ` Miklos Szeredi
2005-11-24 7:46 ` David Woodhouse
2005-11-24 11:24 ` Oleg Drokin
2005-11-26 0:54 ` Hans Reiser
2005-11-24 21:08 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051124100239.GA11074@lst.de \
--to=hch@lst.de \
--cc=aia21@cantab.net \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=green@linuxhacker.ru \
--cc=jdike@addtoit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mm-commits@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=reiserfs-dev@namesys.com \
--cc=rmk@arm.linux.org.uk \
--cc=trond.myklebust@fys.uio.no \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).