From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: + fix-possible-page_cache_shift-overflows.patch added to -mm tree Date: Thu, 24 Nov 2005 11:02:39 +0100 Message-ID: <20051124100239.GA11074@lst.de> References: <200511232121.jANLLo7J024428@shell0.pdx.osdl.net> <200511240200.53265.blaisorblade@yahoo.it> <20051123170903.356b42fc.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Blaisorblade , aia21@cantab.net, dhowells@redhat.com, dwmw2@infradead.org, green@linuxhacker.ru, hch@lst.de, jdike@addtoit.com, linux-fsdevel@vger.kernel.org, miklos@szeredi.hu, neilb@cse.unsw.edu.au, reiserfs-dev@namesys.com, rmk@arm.linux.org.uk, trond.myklebust@fys.uio.no, zippel@linux-m68k.org, mm-commits@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:21966 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S932618AbVKXKD0 (ORCPT ); Thu, 24 Nov 2005 05:03:26 -0500 To: Andrew Morton Content-Disposition: inline In-Reply-To: <20051123170903.356b42fc.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Nov 23, 2005 at 05:09:03PM -0800, Andrew Morton wrote: > > > + start = (long long)page->index << PAGE_CACHE_SHIFT; instead of a construct like this please always use page_offset()