From: Andreas Dilger <adilger@clusterfs.com>
To: Takashi Sato <sho@bsd.tnes.nec.co.jp>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: stat64 for over 2TB file returned invalid st_blocks
Date: Fri, 2 Dec 2005 11:58:05 -0700 [thread overview]
Message-ID: <20051202185805.GS14509@schatzie.adilger.int> (raw)
In-Reply-To: <041701c5f742$d6b0a450$4168010a@bsd.tnes.nec.co.jp>
On Dec 02, 2005 22:18 +0900, Takashi Sato wrote:
> I also found another problem on generic quota code. In
> dquot_transfer(), the file usage is calculated from i_blocks via
> inode_get_bytes(). If the file is over 2TB, the change of usage is
> less than expected.
>
> To solve this problem, I think inode.i_blocks should be 8 byte.
Actually, it should probably be "sector_t", because it isn't really
possible to have a file with more blocks than the size of the block
device. This avoids memory overhead for small systems that have no
need for it in a very highly-used struct. It may be for some network
filesystems that support gigantic non-sparse files they would need to
enable CONFIG_LBD in order to get support for this.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2005-12-02 18:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-01 12:00 stat64 for over 2TB file returned invalid st_blocks Takashi Sato
2005-12-01 12:39 ` Jörn Engel
2005-12-01 12:52 ` Jörn Engel
2005-12-01 13:52 ` Avi Kivity
2005-12-01 14:32 ` Dave Kleikamp
2005-12-02 13:18 ` Takashi Sato
2005-12-02 14:11 ` Dave Kleikamp
2005-12-02 18:58 ` Andreas Dilger [this message]
2005-12-03 13:00 ` Takashi Sato
2005-12-05 8:11 ` Andreas Dilger
2005-12-05 12:35 ` Takashi Sato
2005-12-05 13:34 ` Trond Myklebust
2005-12-01 14:53 ` Al Viro
[not found] <5eVqw-2ug-61@gated-at.bofh.it>
2005-12-03 2:19 ` Bodo Eggert
-- strict thread matches above, loose matches on Subject: below --
2005-12-06 12:42 Takashi Sato
2005-12-06 14:30 ` Dave Kleikamp
2005-12-06 14:48 ` Trond Myklebust
2005-12-06 14:51 ` Dave Kleikamp
2005-12-06 21:24 ` Andreas Dilger
2005-12-07 0:59 ` Trond Myklebust
2005-12-07 10:57 ` Takashi Sato
2005-12-07 13:52 ` Trond Myklebust
2005-12-07 15:01 ` Dave Kleikamp
2005-12-07 15:34 ` Trond Myklebust
2005-12-07 16:34 ` Dave Kleikamp
2005-12-07 18:55 ` Trond Myklebust
2005-12-08 11:38 ` Takashi Sato
2005-12-08 14:27 ` Trond Myklebust
2005-12-08 14:50 ` Anton Altaparmakov
2005-12-08 15:03 ` Trond Myklebust
2005-12-10 11:22 ` Takashi Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051202185805.GS14509@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@austin.ibm.com \
--cc=sho@bsd.tnes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).