From: Matthew Wilcox <matthew@wil.cx>
To: Peter Staubach <staubach@redhat.com>
Cc: ASANO Masahiro <masano@tnes.nec.co.jp>,
trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fix posix lock on NFS
Date: Tue, 3 Jan 2006 12:46:30 -0700 [thread overview]
Message-ID: <20060103194630.GL19769@parisc-linux.org> (raw)
In-Reply-To: <43BAD2EC.2030807@redhat.com>
On Tue, Jan 03, 2006 at 02:39:24PM -0500, Peter Staubach wrote:
> > /* No mandatory locks over NFS */
> >- if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID)
> >+ if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID &&
> >+ fl->fl_type != F_UNLCK)
>
> Just out of curiosity, what is this if() statement intended to protect?
> For locking purposes, why would the client care if the file has the
> mandatory lock bits set?
Mandatory locks aren't mandatory for other clients.
next prev parent reply other threads:[~2006-01-03 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-22 4:24 [PATCH] fix posix lock on NFS ASANO Masahiro
2006-01-03 19:39 ` Peter Staubach
2006-01-03 19:46 ` Matthew Wilcox [this message]
2006-01-03 20:09 ` Peter Staubach
2006-01-04 1:24 ` Trond Myklebust
2006-01-04 14:16 ` Peter Staubach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060103194630.GL19769@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masano@tnes.nec.co.jp \
--cc=staubach@redhat.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).