write_ordered_buffers should handle dirty non-uptodate buffers without a BUG() diff -r 18fa5554d7e2 fs/reiserfs/journal.c --- a/fs/reiserfs/journal.c Fri Jan 13 13:55:10 2006 -0500 +++ b/fs/reiserfs/journal.c Fri Jan 13 14:00:49 2006 -0500 @@ -848,6 +848,14 @@ static int write_ordered_buffers(spinloc spin_lock(lock); goto loop_next; } + /* in theory, dirty non-uptodate buffers should never get here, + * but the upper layer io error paths still have a few quirks. + * Handle them here as gracefully as we can + */ + if (!buffer_uptodate(bh) && buffer_dirty(bh)) { + clear_buffer_dirty(bh); + ret = -EIO; + } if (buffer_dirty(bh)) { list_del_init(&jh->list); list_add(&jh->list, &tmp); @@ -1032,9 +1040,12 @@ static int flush_commit_list(struct supe } if (!list_empty(&jl->j_bh_list)) { + int ret; unlock_kernel(); - write_ordered_buffers(&journal->j_dirty_buffers_lock, - journal, jl, &jl->j_bh_list); + ret = write_ordered_buffers(&journal->j_dirty_buffers_lock, + journal, jl, &jl->j_bh_list); + if (ret < 0 && retval == 0) + retval = ret; lock_kernel(); } BUG_ON(!list_empty(&jl->j_bh_list)); --