From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] O_SYNC error handling fix Date: Mon, 16 Jan 2006 12:11:49 -0800 Message-ID: <20060116121149.1a12b4cf.akpm@osdl.org> References: <200601151943.51771.mason@suse.com> <20060115235852.36a8bcad.akpm@osdl.org> <200601160926.15701.mason@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from smtp.osdl.org ([65.172.181.4]:65430 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751181AbWAPUMN (ORCPT ); Mon, 16 Jan 2006 15:12:13 -0500 To: Chris Mason In-Reply-To: <200601160926.15701.mason@suse.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Chris Mason wrote: > > I can special case the -EIO check for just O_SYNC. I think that along > with changing around the O_DIRECT bits will make us both happy? I guess so... It seems I'm full of crap anyway. We already return -EFOO on failing O_SYNC writes, no?