From: Christoph Hellwig <hch@infradead.org>
To: Ian Kent <raven@themaw.net>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
autofs mailing list <autofs@linux.kernel.org>
Subject: Re: [PATCH] autofs4 - fix comms packet struct size
Date: Mon, 20 Feb 2006 16:00:54 +0000 [thread overview]
Message-ID: <20060220160054.GA31797@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0602200856300.2355@eagle.themaw.net>
On Mon, Feb 20, 2006 at 09:05:59AM +0800, Ian Kent wrote:
> > > autofs_wqt_t wait_queue_token;
> >
> > Hiding types in user visible structures behind typedefs is bad.
> > What type is behind this? If this is not an __u32 you have
> > a padding issue.
>
> This has been an occassion problem for a long time.
> Since it dates back to way before version 4 I have always been reluctant
> to change it. I'd rather leave it as is unless you really can't accept it.
So is this an __u32? ;-)
> OK. But will they be 32 bit for the life of this struct?
If we'd ever bump pid_t or uid_t to 64bits tons of kernel interface
would need to change. And no one guarantees it'd be come an u64
then. So __u32 is the safest choice.
prev parent reply other threads:[~2006-02-20 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-19 14:11 [PATCH] autofs4 - fix comms packet struct size Ian Kent
2006-02-19 14:15 ` Christoph Hellwig
2006-02-20 1:05 ` Ian Kent
2006-02-20 16:00 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060220160054.GA31797@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=autofs@linux.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).