linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <mason@suse.com>
To: suparna@in.ibm.com
Cc: akpm@osdl.org, sct@redhat.com, linux-fsdevel@vger.kernel.org,
	linux-aio@kvack.org, kenneth.w.chen@intel.com,
	pbadari@us.ibm.com, linux-kernel@vger.kernel.org,
	sonny@burdell.org
Subject: Re: [RFC][WIP] DIO simplification and AIO-DIO stability
Date: Thu, 23 Feb 2006 20:01:32 -0500	[thread overview]
Message-ID: <200602232001.34327.mason@suse.com> (raw)
In-Reply-To: <20060223072955.GA14244@in.ibm.com>

On Thursday 23 February 2006 02:29, Suparna Bhattacharya wrote:
> DIO code complexity and stability concerns were discussed way back during
> OLS and Kernel summit last year. Still, the lack of a solid alternative and
> motivation to subject oneself to the test of courage and delicate balance
> that fiddling with this code entails, has meant that gingerly applying
> fixes and bandaids as and when bugs are found, and moving on thereafter,
> continues to be the most palatable option.
>
> A recent AIO-DIO bug reported by Kenneth Chen, came very close
> to being the proverbial last straw for me. Hence, here is a rough attempt
> to put together a (currently WIP) draft towards DIO code simplication,
> based on suggestions that some of you have brought up at various times.
> Several details, e.g. range locking implementation still need to be fleshed
> out completely, ideas/comments/suggestions would be welcome.

I'm really in favor of this, and had actually started an implementation a 
while back.  At the time, I posted a different version that added yet another 
semaphore but simplified the rest of the locking (and held no locks during 
the dio/aio).

I'll try to dig up my original radix tagging code.  I'm not sure if I kept it, 
but it did pass Daniel's dio vs buffer io racing tests at the time.

-chris

  parent reply	other threads:[~2006-02-24  1:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-23  7:29 [RFC][WIP] DIO simplification and AIO-DIO stability Suparna Bhattacharya
2006-02-23 19:12 ` Wendy Cheng
2006-02-24 11:53   ` Suparna Bhattacharya
2006-02-24 15:51     ` Wendy Cheng
2006-02-24  0:39 ` Badari Pulavarty
2006-02-24  1:13   ` Andrew Morton
2006-02-24 11:25     ` Suparna Bhattacharya
2006-02-24  1:01 ` Chris Mason [this message]
2006-02-24  9:37   ` Suparna Bhattacharya
2006-02-24  1:21 ` Zach Brown
2006-02-24 11:12   ` Suparna Bhattacharya
2006-02-24 18:09     ` Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200602232001.34327.mason@suse.com \
    --to=mason@suse.com \
    --cc=akpm@osdl.org \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    --cc=sct@redhat.com \
    --cc=sonny@burdell.org \
    --cc=suparna@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).