From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 6/6] Optimise d_find_alias() [try #6] Date: Wed, 8 Mar 2006 05:14:59 -0700 Message-ID: <20060308121459.GG7301@parisc-linux.org> References: <440D76A4.8050703@yahoo.com.au> <20060307113352.23330.80913.stgit@warthog.cambridge.redhat.com> <20060307113404.23330.71158.stgit@warthog.cambridge.redhat.com> <25795.1141737864@warthog.cambridge.redhat.com> <440E945A.1050404@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@osdl.org, aviro@redhat.com, linux-kernel@vger.kernel.org, nfsv4@linux-nfs.org, steved@redhat.com, David Howells , torvalds@osdl.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org Return-path: To: Nick Piggin Content-Disposition: inline In-Reply-To: <440E945A.1050404@yahoo.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Mar 08, 2006 at 07:22:50PM +1100, Nick Piggin wrote: > Also: I might be talking complete crap here, so anyone feel free to ridicule > me if I'm wrong. No, the smb_rmb() is unnecessary. akpm was the only one who thought we needed it originally, it just somehow stayed into this iteration of the patch.