From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 5/6] NFS: Unify NFS superblocks per-protocol per-server [try #7] Date: Wed, 8 Mar 2006 21:23:52 +0000 Message-ID: <20060308212352.GA7868@infradead.org> References: <20060308203018.25493.23720.stgit@warthog.cambridge.redhat.com> <20060308203028.25493.84121.stgit@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@osdl.org, aviro@redhat.com, linux-kernel@vger.kernel.org, nfsv4@linux-nfs.org, steved@redhat.com, torvalds@osdl.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org Return-path: To: David Howells Content-Disposition: inline In-Reply-To: <20060308203028.25493.84121.stgit@warthog.cambridge.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-Id: linux-fsdevel.vger.kernel.org Everything in nfs4_get_root past the "create a mount to represent the NFS.." comment in nfs4_get_root is generic and not nfs-specific. this should move into a helper in namei.c instead of adding all these odd exports. what it's doing looks a little fishy aswell, but I'll come back to that later.