From: Christoph Hellwig <hch@infradead.org>
To: Nathan Scott <nathans@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, Suzuki <suzuki@in.ibm.com>,
linux-fsdevel@vger.kernel.org,
"linux-aio kvack.org" <linux-aio@kvack.org>,
lkml <linux-kernel@vger.kernel.org>, suparna <suparna@in.ibm.com>,
akpm@osdl.org, linux-xfs@oss.sgi.com
Subject: Re: [RFC] Badness in __mutex_unlock_slowpath with XFS stress tests
Date: Thu, 9 Mar 2006 22:42:19 +0000 [thread overview]
Message-ID: <20060309224219.GA6709@infradead.org> (raw)
In-Reply-To: <20060309223042.GC1135@frodo>
On Fri, Mar 10, 2006 at 09:30:42AM +1100, Nathan Scott wrote:
> Not for reads AFAICT - __generic_file_aio_read + own-locking
> should always have released i_mutex at the end of the direct
> read - are you thinking of writes or have I missed something?
if an error occurs before a_ops->direct_IO is called __generic_file_aio_read
will return with i_mutex still locked. Note that checking for negative
return values is not enough as __blockdev_direct_IO can return errors
aswell.
next prev parent reply other threads:[~2006-03-09 22:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 7:54 [RFC] Badness in __mutex_unlock_slowpath with XFS stress tests Suzuki
2006-03-09 12:03 ` Christoph Hellwig
2006-03-09 22:30 ` Nathan Scott
2006-03-09 22:42 ` Christoph Hellwig [this message]
2006-03-09 23:14 ` Nathan Scott
2006-03-10 0:50 ` Nathan Scott
2006-03-10 15:49 ` Christoph Hellwig
2006-03-14 4:46 ` Suparna Bhattacharya
2006-03-17 17:22 ` Adrian Bunk
2006-03-18 3:34 ` Nathan Scott
2006-03-18 5:03 ` Adrian Bunk
2006-07-10 16:46 ` Stephane Doyon
2006-07-11 0:18 ` Nathan Scott
2006-07-11 13:40 ` Stephane Doyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060309224219.GA6709@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
--cc=nathans@sgi.com \
--cc=suparna@in.ibm.com \
--cc=suzuki@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).