From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC] Badness in __mutex_unlock_slowpath with XFS stress tests Date: Thu, 9 Mar 2006 22:42:19 +0000 Message-ID: <20060309224219.GA6709@infradead.org> References: <440FDF3E.8060400@in.ibm.com> <20060309120306.GA26682@infradead.org> <20060309223042.GC1135@frodo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Suzuki , linux-fsdevel@vger.kernel.org, "linux-aio kvack.org" , lkml , suparna , akpm@osdl.org, linux-xfs@oss.sgi.com Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:2205 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751947AbWCIWmZ (ORCPT ); Thu, 9 Mar 2006 17:42:25 -0500 To: Nathan Scott Content-Disposition: inline In-Reply-To: <20060309223042.GC1135@frodo> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Mar 10, 2006 at 09:30:42AM +1100, Nathan Scott wrote: > Not for reads AFAICT - __generic_file_aio_read + own-locking > should always have released i_mutex at the end of the direct > read - are you thinking of writes or have I missed something? if an error occurs before a_ops->direct_IO is called __generic_file_aio_read will return with i_mutex still locked. Note that checking for negative return values is not enough as __blockdev_direct_IO can return errors aswell.