From: Christoph Hellwig <hch@infradead.org>
To: Robert S Peterson <rpeterso@redhat.com>
Cc: Anton Altaparmakov <aia21@cam.ac.uk>,
Andrew Morton <akpm@osdl.org>,
fs-devel mailing list <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] loop.c to use write ops for fs requiring special locking
Date: Tue, 28 Mar 2006 15:40:18 +0100 [thread overview]
Message-ID: <20060328144018.GA17080@infradead.org> (raw)
In-Reply-To: <1143496322.10856.22.camel@technetium.msp.redhat.com>
On Mon, Mar 27, 2006 at 03:52:02PM -0600, Robert S Peterson wrote:
> Use normal write file operations rather than AOPS prepare_write and
> commit_write when the backing filesystem requires special locking.
NACK. Adding random flags just makes the kernel unmaintainble. The
right thing is to define a proper highlevel interface that can be
implemented properly on all filesystems plus a library helper for
normal pagecache-based filesystems using the aops. There's already
various in-kernel filesystems that would require additional locking
or that aren't pagecache-based at all, please fix them up as part
of the patch(-series).
next prev parent reply other threads:[~2006-03-28 14:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-27 21:52 [PATCH] loop.c to use write ops for fs requiring special locking Robert S Peterson
2006-03-28 0:44 ` Andrew Morton
2006-03-28 15:33 ` Robert S Peterson
2006-03-28 19:27 ` Andrew Morton
2006-03-28 14:40 ` Christoph Hellwig [this message]
2006-03-28 15:59 ` Robert S Peterson
2006-03-29 9:05 ` Christoph Hellwig
2006-03-30 0:10 ` Robert S Peterson
2006-03-30 14:15 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2006-03-01 16:48 [patch] " Robert S Peterson
2006-03-01 22:09 ` Andrew Morton
2006-03-02 10:16 ` Anton Altaparmakov
2006-03-10 23:04 ` Robert S Peterson
2006-03-10 23:13 ` Andrew Morton
2006-03-11 0:36 ` Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060328144018.GA17080@infradead.org \
--to=hch@infradead.org \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).