From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] loop.c to use write ops for fs requiring special locking
Date: Tue, 28 Mar 2006 15:40:18 +0100
Message-ID: <20060328144018.GA17080@infradead.org>
References: <1143496322.10856.22.camel@technetium.msp.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Anton Altaparmakov <aia21@cam.ac.uk>,
	Andrew Morton <akpm@osdl.org>,
	fs-devel mailing list <linux-fsdevel@vger.kernel.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:55718 "EHLO
	pentafluge.infradead.org") by vger.kernel.org with ESMTP
	id S932286AbWC1OkY (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 28 Mar 2006 09:40:24 -0500
To: Robert S Peterson <rpeterso@redhat.com>
Content-Disposition: inline
In-Reply-To: <1143496322.10856.22.camel@technetium.msp.redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Mon, Mar 27, 2006 at 03:52:02PM -0600, Robert S Peterson wrote:
> Use normal write file operations rather than AOPS prepare_write and
> commit_write when the backing filesystem requires special locking.

NACK.  Adding random flags just makes the kernel unmaintainble.  The
right thing is to define a proper highlevel interface that can be
implemented properly on all filesystems plus a library helper for
normal pagecache-based filesystems using the aops.  There's already
various in-kernel filesystems that would require additional locking
or that aren't pagecache-based at all, please fix them up as part
of the patch(-series).