From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 4/7] FS-Cache: Export find_get_pages()
Date: Thu, 20 Apr 2006 17:15:50 -0700
Message-ID: <20060420171550.55f1b125.akpm@osdl.org>
References: <20060420171922.GB21659@infradead.org>
	<20060420165927.9968.33912.stgit@warthog.cambridge.redhat.com>
	<20060420165935.9968.11060.stgit@warthog.cambridge.redhat.com>
	<21746.1145555150@warthog.cambridge.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dhowells@redhat.com, aviro@redhat.com, sct@redhat.com, nfsv4@linux-nfs.org,
	steved@redhat.com, linux-kernel@vger.kernel.org,
	torvalds@osdl.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org
Return-path: <nfsv4-bounces@linux-nfs.org>
To: David Howells <dhowells@redhat.com>
In-Reply-To: <21746.1145555150@warthog.cambridge.redhat.com>
List-Unsubscribe: <http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4>,
	<mailto:nfsv4-request@linux-nfs.org?subject=unsubscribe>
List-Archive: <http://linux-nfs.org/pipermail/nfsv4>
List-Post: <mailto:nfsv4@linux-nfs.org>
List-Help: <mailto:nfsv4-request@linux-nfs.org?subject=help>
List-Subscribe: <http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4>,
	<mailto:nfsv4-request@linux-nfs.org?subject=subscribe>
Sender: nfsv4-bounces@linux-nfs.org
Errors-To: nfsv4-bounces@linux-nfs.org
List-Id: linux-fsdevel.vger.kernel.org

David Howells <dhowells@redhat.com> wrote:
>
> Christoph Hellwig <hch@infradead.org> wrote:
> 
> > > The attached patch exports find_get_pages() for use by the kAFS filesystem
> > > in conjunction with it caching patch.
> > 
> > Why don't you use pagevec ?
> 
> You mean pagevec_lookup() I suppose... That's probably reasonable, though
> slower.
> 

But the code's using pagevecs now.  In a strange manner.

+		nr_pages = find_get_pages(vnode->vfs_inode.i_mapping, first,
+					  PAGEVEC_SIZE, pvec.pages);

that's an open-coded pagevec_lookup().