From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 5/7] FS-Cache: Generic filesystem caching facility
Date: Fri, 21 Apr 2006 11:38:05 -0700
Message-ID: <20060421113805.2ec6fd74.akpm@osdl.org>
References: <20060420174622.6d7390d6.akpm@osdl.org>
	<20060420165927.9968.33912.stgit@warthog.cambridge.redhat.com>
	<20060420165937.9968.57149.stgit@warthog.cambridge.redhat.com>
	<18005.1145628949@warthog.cambridge.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: aviro@redhat.com, sct@redhat.com, nfsv4@linux-nfs.org, steved@redhat.com,
	linux-kernel@vger.kernel.org, dhowells@redhat.com,
	torvalds@osdl.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org
Return-path: <nfsv4-bounces@linux-nfs.org>
To: David Howells <dhowells@redhat.com>
In-Reply-To: <18005.1145628949@warthog.cambridge.redhat.com>
List-Unsubscribe: <http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4>,
	<mailto:nfsv4-request@linux-nfs.org?subject=unsubscribe>
List-Archive: <http://linux-nfs.org/pipermail/nfsv4>
List-Post: <mailto:nfsv4@linux-nfs.org>
List-Help: <mailto:nfsv4-request@linux-nfs.org?subject=help>
List-Subscribe: <http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4>,
	<mailto:nfsv4-request@linux-nfs.org?subject=subscribe>
Sender: nfsv4-bounces@linux-nfs.org
Errors-To: nfsv4-bounces@linux-nfs.org
List-Id: linux-fsdevel.vger.kernel.org

David Howells <dhowells@redhat.com> wrote:
>
> > That's your fourth implementation of kenter().  Maybe we
> > need <linux/dhowells.h>?
> 
> :-)
> 
> Maybe I should move my debugging macros into include/linux, but then everyone
> else would complain if their own versions weren't put in there, or would
> complain if they were forced to use mine.

The number of home-made debugging macro implementations we have is quite
demented.  Developing (and maintaining) a common set would be a good idea,
IMO.

> It doesn't actually produce very much code.
> 
> > Defining symbols which are owned by the Kconfig system isn't very nice.
> 
> Kconfig is still broken:
> 
> 	warthog>grep -r CONFIG_FSCACHE include/linux/autoconf.h 
> 	#define CONFIG_FSCACHE_MODULE 1
> 	warthog>
> 
> Modules that might depend on fscache need to know that it's there,

In theory, module A isn't supposed to care whether module B was configured,
because module B might be compiled separately, or dowloaded from elsewhere
or whatever.

> and having
> to double up every #if to detect both is stupid.
> 
> Would you suggest then:
> 
> 	#if defined(CONFIG_FSCACHE) || defined(CONFIG_FSCACHE_MODULE)
> 	#define FSCACHE_AVAILABLE 1
> 	#endif

yup.