From: Sam Ravnborg <sam@ravnborg.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Adrian Bunk <bunk@stusta.de>,
Steven Whitehouse <swhiteho@redhat.com>,
Andrew Morton <akpm@osdl.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/16] GFS2: Makefiles and Kconfig
Date: Fri, 21 Apr 2006 22:56:39 +0200 [thread overview]
Message-ID: <20060421205639.GA26949@mars.ravnborg.org> (raw)
In-Reply-To: <20060421170753.GW24104@parisc-linux.org>
On Fri, Apr 21, 2006 at 11:07:53AM -0600, Matthew Wilcox wrote:
> On Fri, Apr 21, 2006 at 06:53:51PM +0200, Adrian Bunk wrote:
> > On Fri, Apr 21, 2006 at 10:49:10AM -0600, Matthew Wilcox wrote:
> > > On Fri, Apr 21, 2006 at 06:43:09PM +0200, Adrian Bunk wrote:
> > > > - "depends on SYSFS" instead of the select
> > >
> > > Why? It's more natural to select it rather than depend on it.
> >
> > The rule of thumb is that an option is either user visible and should be
> > depended on or not user visible and should be select'ed.
>
> What rubbish! Who came up with this rule of thumb?
Currently menuconfig makes it a very difficult job to undo a select.
Homework: try to do "make allmodconfig" and then set CONFIG_HOTPLUG=n
You will be hit by CONFIG_FW_LOADER that is 'selected' by many
instances - and then it becomes very difficult.
So until menuconfig has better support for undoing select the rule of
thumb outlined by Adrian is true.
Sam
next prev parent reply other threads:[~2006-04-21 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 16:22 [PATCH 13/16] GFS2: Makefiles and Kconfig Steven Whitehouse
2006-04-21 16:43 ` Adrian Bunk
2006-04-21 16:49 ` Matthew Wilcox
2006-04-21 16:53 ` Adrian Bunk
2006-04-21 17:07 ` Matthew Wilcox
2006-04-21 20:56 ` Sam Ravnborg [this message]
2006-04-21 23:00 ` Greg KH
2006-04-24 13:24 ` Steven Whitehouse
2006-04-24 13:32 ` Steven Whitehouse
2006-04-21 21:01 ` Sam Ravnborg
2006-04-24 13:27 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060421205639.GA26949@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).