From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 13/16] GFS2: Makefiles and Kconfig
Date: Fri, 21 Apr 2006 23:01:39 +0200
Message-ID: <20060421210139.GB26949@mars.ravnborg.org>
References: <1145636558.3856.118.camel@quoit.chygwyn.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Morton <akpm@osdl.org>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S932479AbWDUVBi@vger.kernel.org>
To: Steven Whitehouse <swhiteho@redhat.com>
Content-Disposition: inline
In-Reply-To: <1145636558.3856.118.camel@quoit.chygwyn.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

> --- /dev/null
> +++ b/fs/gfs2/Makefile
> @@ -0,0 +1,42 @@
> +obj-$(CONFIG_GFS2_FS) += gfs2.o
> +gfs2-y := \
> +	acl.o \
> +	bits.o \
> +	bmap.o \
> +	daemon.o \
...
 +	trans.o \
> +	unlinked.o \
> +	util.o
A fewer number of lines please.
gfs2-y := acl.o bits.o bmap.o
...
gfs2-y += trans.o unlinked.o util.o


> +
> +obj-$(CONFIG_GFS2_FS_LOCKING_NOLOCK) += locking/nolock/
> +obj-$(CONFIG_GFS2_FS_LOCKING_DLM) += locking/dlm/
Can we get rid f the locking sub-directory - maybe like this:
+obj-$(CONFIG_GFS2_FS_LOCKING_NOLOCK) += no-lock/
+obj-$(CONFIG_GFS2_FS_LOCKING_DLM     += dlm-lock/

	Sam