From: Greg KH <greg@kroah.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
Andrew Morton <akpm@osdl.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/16] GFS2: Makefiles and Kconfig
Date: Fri, 21 Apr 2006 16:00:35 -0700 [thread overview]
Message-ID: <20060421230035.GA11190@kroah.com> (raw)
In-Reply-To: <20060421164309.GE19754@stusta.de>
On Fri, Apr 21, 2006 at 06:43:09PM +0200, Adrian Bunk wrote:
> > --- /dev/null
> > +++ b/fs/gfs2/Kconfig
> > @@ -0,0 +1,46 @@
> > +config GFS2_FS
> > + tristate "GFS2 file system support"
> > + default m
> > + depends on EXPERIMENTAL
> > + select FS_POSIX_ACL
> > + select SYSFS
> >...
>
> - tabs <-> spaces (tabs are correct)
> - please remove the "default m"
> - "depends on SYSFS" instead of the select
Why do you depend on sysfs at all? If it's not enabled, your code
should still build just fine, right? If not, please let us know and we
will fix the build error in the sysfs.h header file.
thanks,
greg k-h
next prev parent reply other threads:[~2006-04-21 23:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 16:22 [PATCH 13/16] GFS2: Makefiles and Kconfig Steven Whitehouse
2006-04-21 16:43 ` Adrian Bunk
2006-04-21 16:49 ` Matthew Wilcox
2006-04-21 16:53 ` Adrian Bunk
2006-04-21 17:07 ` Matthew Wilcox
2006-04-21 20:56 ` Sam Ravnborg
2006-04-21 23:00 ` Greg KH [this message]
2006-04-24 13:24 ` Steven Whitehouse
2006-04-24 13:32 ` Steven Whitehouse
2006-04-21 21:01 ` Sam Ravnborg
2006-04-24 13:27 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060421230035.GA11190@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).