From: David Teigland <teigland@redhat.com>
To: "Artem B. Bityutskiy" <dedekind@oktetlabs.ru>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
Andrew Morton <akpm@osdl.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/16] GFS2: Mounting & sysfs interface
Date: Tue, 25 Apr 2006 13:04:33 -0500 [thread overview]
Message-ID: <20060425180433.GA17525@redhat.com> (raw)
In-Reply-To: <444E53FC.5060100@oktetlabs.ru>
On Tue, Apr 25, 2006 at 08:53:16PM +0400, Artem B. Bityutskiy wrote:
> Hello,
>
> last time I tried to use "bare" sysfs functions to create my sysfs
> hierarchy I ended up with a problem that the module refcount is not
> increased when those sysfs files are opened. So I could open a sysfs
> file from userspace, do rmmod and enjoy oops.
>
> Then I started using the class and class_device stuff, which have an
> .owner field, and all became fine.
>
> I'm not sure if this is a problem of sysfs, but I suspect it could take
> care of module refcount better.
>
> In your patch, I looked for THIS_MODULE pattern and did not find. I did
> not try, but I suspect your code is not devoid of the problem I
> described. So, this is just FYI and may be not the case.
Others have also alluded to /sys/fs/ races that we'll probably need to
resolve. In this case the question is more about umount than rmmod since
the mount should reference the module.
Thanks,
Dave
next prev parent reply other threads:[~2006-04-25 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 16:21 [PATCH 12/16] GFS2: Mounting & sysfs interface Steven Whitehouse
2006-04-25 16:53 ` Artem B. Bityutskiy
2006-04-25 18:04 ` David Teigland [this message]
2006-04-26 9:53 ` Artem B. Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060425180433.GA17525@redhat.com \
--to=teigland@redhat.com \
--cc=akpm@osdl.org \
--cc=dedekind@oktetlabs.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).