From: Christoph Hellwig <hch@lst.de>
To: Prasanna S Panchamukhi <prasanna@in.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@osdl.org, linux-fsdevel@vger.kernel.org, suparna@in.ibm.com,
maneesh@in.ibm.com, jkenisto@us.ibm.com
Subject: Re: [PATCH] mark address_space_operations const
Date: Tue, 9 May 2006 11:13:35 +0200 [thread overview]
Message-ID: <20060509091335.GA1497@lst.de> (raw)
In-Reply-To: <20060509053039.GA12805@in.ibm.com>
On Tue, May 09, 2006 at 11:00:39AM +0530, Prasanna S Panchamukhi wrote:
> I understand that making file operations .rodata was
> to prevent binary driver authors overriding individual
> file_operations members at runtime.
No, it's not. operation vectors should always be const for correctness.
Msarking them const ensures that, aswell as avoiding false cache
sharing, etc. Nothing about licenses at all.
And example for things this is supposed to prevent is the stuff you did
in the userspace probes after smoking far too much crack.
next prev parent reply other threads:[~2006-05-09 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-03 13:18 [PATCH] mark address_space_operations const Christoph Hellwig
2006-05-09 5:30 ` Prasanna S Panchamukhi
2006-05-09 5:56 ` Greg KH
2006-05-09 7:24 ` Prasanna S Panchamukhi
2006-05-09 9:13 ` Christoph Hellwig [this message]
2006-05-12 11:20 ` Andrew Morton
2006-05-12 18:35 ` [PATCH] CIFS: Do not overwrite aops elements Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060509091335.GA1497@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=jkenisto@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=prasanna@in.ibm.com \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).