From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] mark address_space_operations const Date: Tue, 9 May 2006 11:13:35 +0200 Message-ID: <20060509091335.GA1497@lst.de> References: <20060503131836.GA6991@lst.de> <20060509053039.GA12805@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , akpm@osdl.org, linux-fsdevel@vger.kernel.org, suparna@in.ibm.com, maneesh@in.ibm.com, jkenisto@us.ibm.com Return-path: Received: from verein.lst.de ([213.95.11.210]:40641 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S932277AbWEIJOU (ORCPT ); Tue, 9 May 2006 05:14:20 -0400 To: Prasanna S Panchamukhi Content-Disposition: inline In-Reply-To: <20060509053039.GA12805@in.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, May 09, 2006 at 11:00:39AM +0530, Prasanna S Panchamukhi wrote: > I understand that making file operations .rodata was > to prevent binary driver authors overriding individual > file_operations members at runtime. No, it's not. operation vectors should always be const for correctness. Msarking them const ensures that, aswell as avoiding false cache sharing, etc. Nothing about licenses at all. And example for things this is supposed to prevent is the stuff you did in the userspace probes after smoking far too much crack.